<p></p>
<blockquote>
<p>RE commit <a href="https://github.com/bisq-network/bisq/commit/ab17b672294011b766da3ab6e02a349c01c4f7e0">ab17b67</a>: I was catching exceptions (indicating a bug or bugs to be fixed?) I've seen during testing this method. Otherwise they will bubble up to client.</p>
</blockquote>
<p>I don't see the value in wrapping and rethrowing there. I'd rather see the exception bubble up as-is to the client and then see specific error handling code put wherever it's most appropriate. Wrapping it in an IllegalStateException may not really reflect the nature of the problem, e.g. just a programmer error.</p>
<blockquote>
<p>RE commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/916457963f56747fae53b78de288a774c0865761/hovercard" href="https://github.com/bisq-network/bisq/commit/916457963f56747fae53b78de288a774c0865761"><tt>9164579</tt></a>: I don't think an extra line for an explicit return; is needed for methods that return void.</p>
</blockquote>
<p>If you don't explicitly return there, then the next<code>if</code> block will return <code>true</code> and throw because you just finished encrypting the wallet. Prior to your refactoring, you did explicitly return from that block with a <code>Tuple2</code>. You either need to return or make the subsequent <code>if</code> an <code>else if</code> block; your call.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4214#issuecomment-623149720">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTUU42DUSXAHITU7FTRPWTQ3ANCNFSM4MUIOB4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQNI3KDS7QFJ264DCTRPWTQ3A5CNFSM4MUIOB42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUSIFGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623149720",
"url": "https://github.com/bisq-network/bisq/pull/4214#issuecomment-623149720",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>