<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cd2357/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cd2357">@cd2357</a>, a couple notes on commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/e18f0406af08aebfa2b4448f5bdf02198eaf1510/hovercard" href="https://github.com/bisq-network/bisq/commit/e18f0406af08aebfa2b4448f5bdf02198eaf1510"><tt>e18f040</tt></a>:</p>
<ul>
<li>Per <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="319178416" data-permission-text="Title is private" data-url="https://github.com/bisq-network/style/issues/9" data-hovercard-type="issue" data-hovercard-url="/bisq-network/style/issues/9/hovercard" href="https://github.com/bisq-network/style/issues/9">bisq-network/style#9</a>, please wrap commit message bodies at 72 chars.</li>
<li>The <code>Fixes projects/issues/27</code> you included in the message body used incorrect syntax (should be <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="579705286" data-permission-text="Title is private" data-url="https://github.com/bisq-network/projects/issues/27" data-hovercard-type="issue" data-hovercard-url="/bisq-network/projects/issues/27/hovercard" href="https://github.com/bisq-network/projects/issues/27">bisq-network/projects#27</a>. More importantly, though, this PR does not actually "fix" or "resolve" that issue. That issue is a larger project proposal, and would have stayed open regardless whether this PR were merged or not. In such cases, it's better to avoid the special <a href="https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword">closing keywords</a> and simply say <code>See bisq-network/projects#27</code> or <code>This is a stopgap measure related to bisq-network/projects#27</code>, etc, so that the links still get established.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4235#issuecomment-624460407">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQBM7XWWEI4FXLX2TLRQD5SBANCNFSM4MZUZ4TQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXERZIFT4AP64B5ZVTRQD5SBA5CNFSM4MZUZ4T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEU4IE5Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4235#issuecomment-624460407",
"url": "https://github.com/bisq-network/bisq/pull/4235#issuecomment-624460407",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>