<p></p>
<p><b>@cbeams</b> approved this pull request.</p>

<p>ACK.</p>
<blockquote>
<p>I've made a fix to handle the 404 return code when addresses are all empty.</p>
</blockquote>
<p>Thanks for the fix. I've tested this locally and it works as expected for me, including when one of the addresses does have transactions.</p>
<blockquote>
<p>Feel free to make your changes too, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cbeams/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a>. I don't know why you experienced the inability to make changes, as stated earlier the box "allow edits" is and always has been checked.</p>
</blockquote>
<p>My normal workflow was thrown off because you made these changes on your master branch. Not a big deal, I've now pushed my changes and will merge everything shortly. But in the future, please issue pull requests from a branch dedicated to that PR. This is especially important when you're working in a higher-traffic repository like bisq-network/bisq.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/support/pull/399#pullrequestreview-407187587">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNU33VADJFQNLOORADLRQJKA7ANCNFSM4MYX6KPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQ4J63KEES6KB3I7UDRQJKA7A5CNFSM4MYX6KP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODBCTBAY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/support/pull/399#pullrequestreview-407187587",
"url": "https://github.com/bisq-network/support/pull/399#pullrequestreview-407187587",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>