<p></p>
<p>I notice you have added a new storage class for transactions. There is already the bitcoinj Transaction which stores the transactions and has a memo field. What was the reasons for not using that? I suppose those transactions would be lost in an SPV resync. Just feels like quite a bit of extra work to store the memo field separately like this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4229#issuecomment-625727576">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXP7BI6POM3XTS6GZLRQPF3FANCNFSM4MX5P7CA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRQUEHX6RWZVWBWDBLRQPF3FA5CNFSM4MX5P7CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEVF5QWA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4229#issuecomment-625727576",
"url": "https://github.com/bisq-network/bisq/pull/4229#issuecomment-625727576",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>