<p></p>
<p><b>@petrhejna</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4228#discussion_r422619810">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>:</p>
<pre style='color:#555'>>          areaChart.getData().addAll(List.of(seriesBuy, seriesSell));
     }
 
+    /**
+     * A node which displays a label on hover, but is otherwise empty
+     *
+     * Based on https://gist.github.com/jewelsea/1422628
+     */
+    protected class HoveredLabelNode extends StackPane {
</pre>
<p>I would move this Node to the separate file and pass data via constructor (the price -><code>xAxis.getTickLabelFormatter().toString(price)</code>.</p>
<p>This file is quite long already and this is separable responsibility.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4228#pullrequestreview-408727812">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNT6GLJGQ576BN5WM73RQZ2LBANCNFSM4MX3Z2OQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVJRSXXN2DJDQB4NRDRQZ2LBA5CNFSM4MX3Z2O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODBOLCBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4228#pullrequestreview-408727812",
"url": "https://github.com/bisq-network/bisq/pull/4228#pullrequestreview-408727812",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>