<p></p>
<p><b>@jmacxx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4193#discussion_r425307021">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -118,6 +121,23 @@ String getMarketLabel(OpenOfferListItem item) {
         return CurrencyUtil.getCurrencyPair(item.getOffer().getCurrencyCode());
     }
 
+    String getPaymentMethod(OpenOfferListItem item) {
+        String result = "";
+        if (item != null) {
+            Offer offer = item.getOffer();
+            checkNotNull(offer);
+            checkNotNull(offer.getPaymentMethod());
+            String method = Res.get(offer.getPaymentMethod().getId() + "_SHORT");
</pre>
<p><g-emoji class="g-emoji" alias="+1" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji> Done / refactored.  <code>Res.get</code> handles <code>MissingResourceException</code> itself and in that case returns the key.  I think that is a good way of handling the case of missing translations since it alleviates the caller from having to write custom error handling everywhere.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4193#discussion_r425307021">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVK263YFUDF37EU7TDRRQSKXANCNFSM4MPQDYPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQX2ZKUQ2G2VWV6JCDRRQSKXA5CNFSM4MPQDYPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCHQVOI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4193#discussion_r425307021",
"url": "https://github.com/bisq-network/bisq/pull/4193#discussion_r425307021",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>