<p></p>
<p><b>@dmos62</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4168#discussion_r425076689">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -333,7 +333,14 @@ private void updateChartData() {
buildChartAndTableEntries(allSellOffers, OfferPayload.Direction.SELL, sellData, topSellOfferList);
}
- private Comparator<Offer> getComparator(boolean reversePrimarySortOrder) {
+ /**
+ * Returns a comparator to be used for Offers. Sorts primarily for price and
+ * secondarily for offer volume.
+ *
+ * @param reversePrimarySortOrder
+ * @return
+ */
+ private Comparator<Offer> getComparatorWithSecondarySortOrder(boolean reversePrimarySortOrder) {
</pre>
<p>Not requesting this change, since the whole method should be unnecessary.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4168#discussion_r425076689">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQSJFMCFQORT3U6C6TRRPLJBANCNFSM4MHZK4TQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSUJQRUR7FJYIIFYIDRRPLJBA5CNFSM4MHZK4T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCFG5HA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4168#discussion_r425076689",
"url": "https://github.com/bisq-network/bisq/pull/4168#discussion_r425076689",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>