<p></p>
<p><b>@dmos62</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4193#discussion_r425250142">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java</a>:</p>
<pre style='color:#555'>> @@ -118,6 +121,23 @@ String getMarketLabel(OpenOfferListItem item) {
         return CurrencyUtil.getCurrencyPair(item.getOffer().getCurrencyCode());
     }
 
+    String getPaymentMethod(OpenOfferListItem item) {
+        String result = "";
+        if (item != null) {
+            Offer offer = item.getOffer();
+            checkNotNull(offer);
+            checkNotNull(offer.getPaymentMethod());
+            String method = Res.get(offer.getPaymentMethod().getId() + "_SHORT");
</pre>
<p>It would be a good to move this duplicating logic to <a href="https://github.com/bisq-network/bisq/blob/master/core/src/main/java/bisq/core/payment/payload/PaymentMethod.java"><code>PaymentMethod</code></a> itself (<code>PaymentMethod.getShortName()</code> or something better). Put in a try-catch in that method for <code>java.util.MissingResourceException</code> (that's what <code>Res.get</code> might throw) and use an Option return type to distinguish whether or not the translation was found (again, since we can't guarantee (I presume) that someone won't forget to put in a translation when adding a new payment method).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4193#discussion_r425250142">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVNNWI23AUF73RB6ADRRQIQPANCNFSM4MPQDYPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXKJT5FNWG4WOKVWHDRRQIQPA5CNFSM4MPQDYPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCG6JCI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4193#discussion_r425250142",
"url": "https://github.com/bisq-network/bisq/pull/4193#discussion_r425250142",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>