<p>This fixes an issue whereby updates from the fee API were causing Insufficient Funds exception.  Since the wallet is funded with a specific amount (deposit+trade fee+txFee), that same amount has<br>
to be used when the user confirms offer creation (<a href="https://github.com/bisq-network/bisq/issues/4227#issuecomment-629521456" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4227/hovercard">which could be some time later</a>).</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #4227.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="611264337" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4227" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4227/hovercard" href="https://github.com/bisq-network/bisq/issues/4227">#4227</a></p>
<p>Desktop Bisq <code>createAndGetOffer</code>needs to pass a fee value to <code>CreateOfferService</code> but <code>CoreApi::placeOffer</code> does not pass one, so had pass from there a dummy fee of Coin.ZERO which would equate to existing functionaliy, i.e. get current appropriate fee.<br>
<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a> and <a class="team-mention js-team-mention" data-error-text="Failed to load team members" data-id="3638643" data-permission-text="Team members are private" data-url="/orgs/bisq-network/teams/bisq-devs/members" data-hovercard-type="team" data-hovercard-url="/orgs/bisq-network/teams/bisq-devs/hovercard" href="https://github.com/orgs/bisq-network/teams/bisq-devs">@bisq-network/bisq-devs</a> , requesting your input here.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4266'>https://github.com/bisq-network/bisq/pull/4266</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Create order using the same tx fee specified at funding</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4266/files#diff-6fd3a1bb17b4e9d1355ef9a5afc364e9">core/src/main/java/bisq/core/grpc/CoreApi.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4266/files#diff-fa9562b880bebb7747aea6a3a91898c2">core/src/main/java/bisq/core/offer/CreateOfferService.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4266/files#diff-d3649e35cf1413cc3bbeada9ca9f0263">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4266.patch'>https://github.com/bisq-network/bisq/pull/4266.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4266.diff'>https://github.com/bisq-network/bisq/pull/4266.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4266">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQKKUN3VGGZ4GBJCX3RSAJWHANCNFSM4NDO2J7A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNW7IVERGPAY4RUNHD3RSAJWHA5CNFSM4NDO2J7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JHQVHGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4266",
"url": "https://github.com/bisq-network/bisq/pull/4266",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>