<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cbeams/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> I agree a PR example is a good idea.</p>
<p>The 1:1 wrap part is just to get the foundation for where to move BitcoinJ-specific logic. I.e. the refactoring happens on top of that. You'd move the logic in one set of commits (like in the sketch) and then you'd most likely simplify it in another set of commits (not in the sketch).</p>
<p>At first I was thinking of calling it <code>btc.client</code>, since it would handle all Bitcoin networking, but then realised that actually the <code>bisq.core.btc</code> package is our Bitcoin client, and the proposed package would be the lowest-level of that client, hence the <code>bisq.core.btc.low</code>. It's low-level in that it hides BitcoinJ logic that the rest of the <code>btc</code> package shouldn't care about and exposes the basic interface that the rest of the <code>btc</code> package will use. It makes sense to me at this point, but that might change and I don't have strong feelings either way.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/projects/issues/30#issuecomment-630119561">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUDVEZDFLSTTP7ZZR3RSELTLANCNFSM4MPSVBDA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVGYFIYCDVT63RGBM3RSELTLA5CNFSM4MPSVBDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEWHNZCI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/projects/issues/30#issuecomment-630119561",
"url": "https://github.com/bisq-network/projects/issues/30#issuecomment-630119561",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>