<p></p>
<p><b>@cbeams</b> requested changes on this pull request.</p>

<p>NACK. I've just merged <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="609410256" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4214" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4214/hovercard" href="https://github.com/bisq-network/bisq/pull/4214">#4214</a>, and attempted to merge this as well, but there are a number of test failures. One fragile one is exact string matching on version (it's 1.3.2 in the tests but 1.3.4 on master right now). There are some other failures as well that weren't obvious to me at a glance.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4243#pullrequestreview-413546509">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX2NFF6UKPFGXYKF5LRSES6VANCNFSM4M3Q5XCA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQJAV7KO3MBHMFPINLRSES6VA5CNFSM4M3Q5XCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCTDQDI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4243#pullrequestreview-413546509",
"url": "https://github.com/bisq-network/bisq/pull/4243#pullrequestreview-413546509",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>