<p></p>
<p><b>@freimair</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4233#discussion_r428525243">p2p/src/main/java/bisq/network/p2p/storage/persistence/SplitStoreService.java</a>:</p>
<pre style='color:#555'>> +
+ @Override
+ protected void readFromResources(String postFix) {
+ // check Version.VERSION and see if we have latest r/o data store file in working directory
+ if (!new File(absolutePathOfStorageDir + File.separator + getFileName() + "_" + Version.VERSION).exists())
+ makeFileFromResourceFile(postFix); // if we have the latest file, we are good, else do stuff // TODO are we?
+ else {
+ // load stores/storage
+ File dbDir = new File(absolutePathOfStorageDir);
+ List<File> resourceFiles = Arrays.asList(dbDir.list((dir, name) -> name.startsWith(getFileName() + "_"))).stream().map(s -> new File(s)).collect(Collectors.toList());
+
+ history = new HashMap<>();
+ store = readStore(getFileName());
+ resourceFiles.forEach(file -> {
+ SplitStore tmp = readStore(file.getName().replace(postFix, ""));
+ history.put(file.getName().replace(postFix, "").replace(getFileName(), "").replace("_", ""), tmp);
</pre>
<p>just added some additional logic to address this issue.</p>
<p>I could not stay true to the rest of the coding style and did my own design. And by doing that, I saved on 30 loc.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4233#discussion_r428525243">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXPL6WMJYYNTQGO5OTRSTS43ANCNFSM4MY33J4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSINDEGJJJDHKIXGADRSTS43A5CNFSM4MY33J4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODDFVLYI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4233#discussion_r428525243",
"url": "https://github.com/bisq-network/bisq/pull/4233#discussion_r428525243",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>