<p></p>
<p>I created a patch (on top of <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/1b86a7d3cd661e308ff7b38b86fef81e6c11706c/hovercard" href="https://github.com/bisq-network/bisq/commit/1b86a7d3cd661e308ff7b38b86fef81e6c11706c"><tt>1b86a7d</tt></a>) breaking up the above method into 3 separate methods to make it a bit more testable, by avoiding the RNG nondeterminism. I also added some unit tests and fixed a slight issue with the above that an exception is thrown if all the recipient address+weight pairs are unparseable, instead of just some of them.</p>
<p>Feel free not to use it or to make further changes. I tested the patch on regtest and it seems to work with the weighted addresses. I'm also fairly sure the above would have worked as well.</p>
<p>It seems that my earlier confusion about the filter not being successfully broadcast was due to <code>FilterManager</code> exposing two separate <code>Filter</code> properties: <code>UserPayload.developersFilter</code> (stored locally, shown in the filter view and broadcast when adding a new filter) and <code>FilterManager.filterProperty</code> (loaded by each peer from the network and used for the actual filtering). Adding a filter on one node (say the mediator) did successfully apply it to the receiver address selection on the other nodes upon further testing, so I'm fairly sure there's no problem.</p>
<p><a href="https://github.com/bisq-network/bisq/files/4694479/Add_weights_to_fee_receiver_addresses.patch.txt">Add_weights_to_fee_receiver_addresses.patch.txt</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4150#issuecomment-635221494">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRTPT3QF6X67HZLPUDRTYTQDANCNFSM4MEJRK3Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNX7TEHNT5P7DAN6H5DRTYTQDA5CNFSM4MEJRK32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEXOLL5Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4150#issuecomment-635221494",
"url": "https://github.com/bisq-network/bisq/pull/4150#issuecomment-635221494",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>