<p>This is a way for legacy arbitrators to repair some of the lost data in the signedwitness store. With ctrl+O from legacy arbitrator support view <code>SignUnsignedPubKeysWindow</code> is opened.</p>
<p>There is no change to current behavior of Bisq for a normal user in this PR.</p>
<p>Some more debug log shortcuts have been added as ctrl+shift+key under <code>PaymentAccountsView</code></p>
<p>At the moment <code>SignSpecificWitnessWindow</code> is not that interesting, but it might be a good thing to have in the future. It's a way for arbitrators to sign specific <code>AccountAgeWitnesses</code>.</p>
<p>Some logging code from <code>AccountAgeWitnessService</code> was moved to a separate class.</p>
<p><code>cleanSignedWitnesses</code> in <code>SignedWitnessService</code> is not yet in use, but it should probably be used soon. I don't want to enable it in this PR as it would change current behavior, and it also needs persistence to be fixed.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4280'>https://github.com/bisq-network/bisq/pull/4280</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Arbitrator sign single account age witness</li>
  <li>Test dummy account age witness signing</li>
  <li>Refactor accountagewitnessservice log helpers</li>
  <li>Arbitrator signing of AccountAgeWitness with known pubkey</li>
  <li>Log unique unsigned signer pubkeys</li>
  <li>Sign unsigned keys</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-2766cb2f2ba0694ce0184276106f8092">common/src/main/java/bisq/common/util/Utilities.java</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-ca6058d9f041f31aaa9e29360e2d60a3">core/src/main/java/bisq/core/account/sign/SignedWitness.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-d9deee426c480d8631711c8b147bbfa4">core/src/main/java/bisq/core/account/sign/SignedWitnessService.java</a>
    (95)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-a52b4824e9a7e21f9c9bf6de3dbe1e3a">core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java</a>
    (115)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-98e772d3c63baff678916044d94d1c43">core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java</a>
    (171)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-96efa0a35cd731d026729dd38fde05c1">core/src/main/java/bisq/core/trade/protocol/ProcessModel.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-2b16c2ca0e92ce28cd7268b07a143647">core/src/main/resources/i18n/displayStrings.properties</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-2c4ac1de579d9cf2721f70b0da448dd4">core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java</a>
    (150)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-296633c9e245a5277e6db104229d351c">desktop/src/main/java/bisq/desktop/main/account/content/PaymentAccountsView.java</a>
    (22)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-543286cc5e3f5a7101b50596bc50d4c2">desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java</a>
    (208)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-107b610acf5b698fbc0cc46153eeeb13">desktop/src/main/java/bisq/desktop/main/overlays/windows/SignUnsignedPubKeysWindow.java</a>
    (196)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-0d35c020d57d4de55ebb1d863f6b7b25">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4280/files#diff-6c632874dafc703d50a1e492b30b4bd9">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/arbitration/ArbitratorView.java</a>
    (14)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4280.patch'>https://github.com/bisq-network/bisq/pull/4280.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4280.diff'>https://github.com/bisq-network/bisq/pull/4280.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4280">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVCS3AOEQLMY7SY27TRUZK4FANCNFSM4NRWTYEA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRDZMKU6M5XBTJ4CPDRUZK4FA5CNFSM4NRWTYEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JMNQDJQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4280",
"url": "https://github.com/bisq-network/bisq/pull/4280",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>