<p>This change is a refactoring of the gRPC <code>Wallets</code> service for the purpose of making <code>CoreApi</code> the entry point to  all core implementations.</p>
<p>Seeing <code>GrpcWalletsService</code> using <code>CoreWalletsService</code> (that's sensible) made me hesitate to make this change, but if <code>GrpcWalletsService</code> doesn't use <code>CoreApi</code> instead of <code>CoreWalletsService</code>, then we set up an inconsistent situation where some <code>Grpc*Service</code> impls use <code>CoreApi</code> and some do not.  I think it is better to be consistent for myself other devs, and consistently inject only <code>CoreApi</code> into each <code>Grpc*Service</code>, instead of a variable number of core services.</p>
<p>Also, the gRPC <code>Wallet</code> proto def name was changed to <code>Wallets</code> because this service manages BSQ and BTC wallets;  <code>GrpcWalletService</code> was renamed to <code>GrpcWalletsService</code> for the same reason.   (This change should have been made in PR <a href="https://github.com/bisq-network/bisq/pull/4295" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4295/hovercard">4295</a>).</p>
<p>This PR should be reviewed/merged after PR <a href="https://github.com/bisq-network/bisq/pull/4308" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4308/hovercard">4308</a>.<br>
(This PR's branch was created from the PR 4308 branch.)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4309'>https://github.com/bisq-network/bisq/pull/4309</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Rename CoreWalletService -> CoreWalletsService</li>
  <li>Add rpc wallet(s) protection tests</li>
  <li>Add rpc method 'getfundingaddresses'</li>
  <li>Replace duplicate code in getFundingAddresses</li>
  <li>Add rpc method 'getaddressbalance'</li>
  <li>Add rpc method 'createpaymentacct'</li>
  <li>Call core wallets service methods from CoreApi</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-c373779aeb2c0f02199d152b537b0fd1">cli/src/main/java/bisq/cli/CliMain.java</a>
    (81)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-9368479f5696839c056de9f5b7d62e7b">cli/test.sh</a>
    (116)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-6fd3a1bb17b4e9d1355ef9a5afc364e9">core/src/main/java/bisq/core/grpc/CoreApi.java</a>
    (63)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-3efc42f52c2f2ee78321c2271af3cdf2">core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java</a>
    (57)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-bea89058b2c63aeec792f281435a4ec6">core/src/main/java/bisq/core/grpc/CoreWalletsService.java</a>
    (112)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-fa31cf62eef287705e52b4c7d3a86a59">core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java</a>
    (46)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-64eb5835ca37d8f1ab4af8939934a860">core/src/main/java/bisq/core/grpc/GrpcServer.java</a>
    (26)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-5cdf4f3ac7fd2fd81e70964f9665591a">core/src/main/java/bisq/core/grpc/GrpcWalletsService.java</a>
    (54)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4309/files#diff-328b3309bc03d9ffb3ffb9e780dc7e91">proto/src/main/proto/grpc.proto</a>
    (38)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4309.patch'>https://github.com/bisq-network/bisq/pull/4309.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4309.diff'>https://github.com/bisq-network/bisq/pull/4309.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4309">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWO4HDREVFZKXNOCNTRWZ5CZANCNFSM4N6SJE5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTLJ6W6YSNGJHYG45DRWZ5CZA5CNFSM4N6SJE5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JQYCIZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4309",
"url": "https://github.com/bisq-network/bisq/pull/4309",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>