<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/dmos62/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/dmos62">@dmos62</a> thanks for your review. Appreciate it.</p>
<p>First of all, your PR description is correct.</p>
<p>Furthermore, I believe I can address all of your comments in summary:<br>
I see this PR as an as-small-as-possible fix for the 3/4 problem. Yes, files are copied around where they probably do not need to be, APIs could be more readable, return values are ignored or misused, and a lot of other stuff. Thing is, most of the issues you raised have been in the code already and I do not want to touch them. They have proven themselves. Keep the changes small, keep the isolated. Its a minefield.</p>
<p>That being said, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="595721729" data-permission-text="Title is private" data-url="https://github.com/bisq-network/projects/issues/29" data-hovercard-type="issue" data-hovercard-url="/bisq-network/projects/issues/29/hovercard" href="https://github.com/bisq-network/projects/issues/29">bisq-network/projects#29</a> is in the queue. That project will get rid of the copying files around because there will be no more individual files, the API will need a major overhaul, the filter might get enhanced, the <code>isSeednode</code> code will be gone because it prevents our network to fall apart while upgrading from single data stores (now) to multiple (then) -After that is done, it is no longer needed.</p>
<p>Now to your obvious question: why not do it properly? I rather not spend time on reworking the same thing twice <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji> because I am a) a lazy bastard, and b) we need to use the resources we have efficiently. And of course, coding styles and our brains differ, so there is no perfect PR anyways.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4233#issuecomment-644742531">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNULRDYETJK5IQXZ6IDRW5TILANCNFSM4MY33J4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXCAQM42HTZZFVR47DRW5TILA5CNFSM4MY33J4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEZW73AY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4233#issuecomment-644742531",
"url": "https://github.com/bisq-network/bisq/pull/4233#issuecomment-644742531",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>