<p></p>
<p><b>@dmos62</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4308#discussion_r443657629">cli/src/main/java/bisq/cli/CliMain.java</a>:</p>
<pre style='color:#555'>> +                }
+                case createpaymentacct: {
+                    if (nonOptionArgs.size() < 2)
+                        throw new IllegalArgumentException("no account name specified");
+
+                    var accountName = nonOptionArgs.get(1);
+
+                    if (nonOptionArgs.size() < 3)
+                        throw new IllegalArgumentException("no account number specified");
+
+                    var accountNumber = nonOptionArgs.get(2);
+
+                    if (nonOptionArgs.size() < 4)
+                        throw new IllegalArgumentException("no fiat currency specified");
+
+                    var fiatCurrencyCode = nonOptionArgs.get(3).toUpperCase();
</pre>
<p><code>.toUpperCase()</code> seems misplaced here. It would soon get repetive. Whether the underlying logic differentiates between capitalizations is a low-level implementation detail and would do better at the lowest practical level.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4308#pullrequestreview-435055483">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW3BCFCOQUQLXNANNLRX56OLANCNFSM4N6MWJDQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTCMDJJRWWA4XB3IHDRX56OLA5CNFSM4N6MWJD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODHXGW6Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4308#pullrequestreview-435055483",
"url": "https://github.com/bisq-network/bisq/pull/4308#pullrequestreview-435055483",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>