<p></p>
<p><b>@dmos62</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4329#discussion_r444400867">core/src/main/java/bisq/core/grpc/CoreApi.java</a>:</p>
<pre style='color:#555'>> +                            PaymentAccount paymentAccount,
+                            boolean useSavingsWallet,
+                            TransactionResultHandler resultHandler) {
+        coreOffersService.createOffer(offerId,
+                currencyCode,
+                direction,
+                price,
+                useMarketBasedPrice,
+                marketPriceMargin,
+                amount,
+                minAmount,
+                buyerSecurityDeposit,
+                paymentAccount,
+                useSavingsWallet,
+                resultHandler);
+    }
</pre>
<p>It took me a minute to realise that the difference between these methods is that one of them takes primitives and the other takes higher level abstractions. I'm leaving this comment as an annotation for myself.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4329#pullrequestreview-436016794">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRNO5HXQCG4FR7TBJ3RYDTC7ANCNFSM4OE4ZSBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV7B3F4J2LQ66K76DLRYDTC7A5CNFSM4OE4ZSBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODH6RNGQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4329#pullrequestreview-436016794",
"url": "https://github.com/bisq-network/bisq/pull/4329#pullrequestreview-436016794",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>