<p>While testing <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="637253316" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4294" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4294/hovercard" href="https://github.com/bisq-network/bisq/pull/4294">#4294</a> I recognized that when adding a new filter object to the network one of my regtest nodes got its filter reset. This was caused by a timing issue that the added filter message was received before the removed filter message. In that case the filter was reset and the new filter never applied. This is only a problem during runtime when a new filter is set. After a restart the correct filter is applied. This PR adds a equals check to prevent the reseting of a filter by mistake. As the added filter message overwrites all fields anyways not having the removed filter message is not essential.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4335'>https://github.com/bisq-network/bisq/pull/4335</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add equals check to prevent resetting of newly set Filter</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4335/files#diff-50f4ec462f015eeca1788f59e768e6b2">core/src/main/java/bisq/core/filter/FilterManager.java</a>
    (3)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4335.patch'>https://github.com/bisq-network/bisq/pull/4335.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4335.diff'>https://github.com/bisq-network/bisq/pull/4335.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4335">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNU6MI64HZMSUH4T453RYMTQJANCNFSM4OIHXMCQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXK46NTA2J6PS3AQSLRYMTQJA5CNFSM4OIHXMC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JTY7GVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4335",
"url": "https://github.com/bisq-network/bisq/pull/4335",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>