<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r453990776">apitest/src/main/java/bisq/apitest/config/BisqAppConfig.java</a>:</p>
<pre style='color:#555'>> +            5122,
+            -1),
+    bobdaemon("bisq-BTC_REGTEST_Bob_dao",
+            "bisq-daemon",
+            "\"-XX:MaxRAM=2g -Dlogback.configurationFile=apitest/build/resources/main/logback.xml\"",
+            BisqDaemonMain.class.getName(),
+            8888,
+            5123,
+            9999),
+    bobdesktop("bisq-BTC_REGTEST_Bob_dao",
+            "bisq-desktop",
+            "\"-XX:MaxRAM=4g -Dlogback.configurationFile=apitest/build/resources/main/logback.xml\"",
+            BisqAppMain.class.getName(),
+            8888,
+            5123,
+            -1);
</pre>
<p>Limiting RAM for <code>bisq-apitest</code> was not necessary -- and removed from the <code>bisq-apitest</code> script -- because it is a headless app.  But we need to limit RAM for <code>:desktop</code> apps started by <code>bisq-apitest</code>, like we do for the Linux Bisq UI.</p>
<p>Above, you mentioned:</p>
<blockquote>
<blockquote>
<p>Is this to do with bisq using too much RAM in some cases? But wasn't that only relevant for long-running processes?</p>
</blockquote>
</blockquote>
<p>The Bisq UI is using too much without this limit, especially when starting it on an empty datadir.  This is why <code>BisqAppConfig</code> has a larger limit for <code>bobdesktop</code> than <code>bobdaemon</code>.  It's not really necessary for daemons at this stage, but it might be useful for profiling long running tests in the future.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r453990776">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXPUNPITNWCCB4SATDR3OFOJANCNFSM4OV5LEEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVGYFDEZ6GIFTLQU6LR3OFOJA5CNFSM4OV5LEE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODKXM3GA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4366#discussion_r453990776",
"url": "https://github.com/bisq-network/bisq/pull/4366#discussion_r453990776",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>