<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r456659445">apitest/src/main/resources/bitcoin.conf</a>:</p>
<pre style='color:#555'>> +# This file is overwritten by ApiTestConfig.java at startup, to set the correct blocknotify script path.
+regtest=1
+
+[regtest]
+peerbloomfilters=1
+rpcport=18443
+
+server=1
+txindex=1
+
+# TODO migrate to rpcauth
+rpcuser=apitest
+rpcpassword=apitest
+
+# The blocknotify path will be defined and at runtime.
+# blocknotify=bash ~/.bitcoin/blocknotify %
</pre>
<p>Passing all <code>bitcoind</code> parameters inline is cleaner.  It's one less file the test harness has to write & install, and the <code>bitcoind</code> configuration is clearly visible in the 'apitest' logfile.   Fixed in commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/f7d8c0e5c3957e45ac7e987d2a7368594cc8789c/hovercard" href="https://github.com/bisq-network/bisq/commit/f7d8c0e5c3957e45ac7e987d2a7368594cc8789c"><tt>f7d8c0e</tt></a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r456659445">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRB2XUF3CIQMXFCNCTR4CYBXANCNFSM4OV5LEEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSPVYFY7362WXWKHHDR4CYBXA5CNFSM4OV5LEE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODLQMO2I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4366#discussion_r456659445",
"url": "https://github.com/bisq-network/bisq/pull/4366#discussion_r456659445",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>