<p></p>
<p><b>@m52go</b> requested changes on this pull request.</p>
<p>I tested again throughout the site and everything seems to work fine. It looks so good (!).</p>
<p>I've attached a couple of nitpicks in the JavaScript...there's a stray <code>console.out()</code> still there from debugging and an unused condition in 2 of the if statements.</p>
<p>That's it from my end. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/pedromvpg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/pedromvpg">@pedromvpg</a> I will ACK once you make those changes, and merge a short while afterward if there's no other feedback.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/378#discussion_r462710956">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -120,6 +121,21 @@
</head>
<body class="home page-template-default page page-id-6 custom-background">
+ <script>
+ if (Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: light)').matches) {
</pre>
⬇️ Suggested change
<pre style="color: #555">- if (Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: light)').matches) {
+ if (Cookies.get('darkmode') === undefined && window.matchMedia('(prefers-color-scheme: light)').matches) {
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/378#discussion_r462711030">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -120,6 +121,21 @@
</head>
<body class="home page-template-default page page-id-6 custom-background">
+ <script>
+ if (Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: light)').matches) {
+ console.log('no cookie');
</pre>
⬇️ Suggested change
<pre style="color: #555">- console.log('no cookie');
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-website/pull/378#discussion_r462711099">_layouts/default.html</a>:</p>
<pre style='color:#555'>> @@ -120,6 +121,21 @@
</head>
<body class="home page-template-default page page-id-6 custom-background">
+ <script>
+ if (Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: light)').matches) {
+ console.log('no cookie');
+ Cookies.set("darkmode", 0);
+ }else if(Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
</pre>
⬇️ Suggested change
<pre style="color: #555">- }else if(Cookies.get('darkmode') === undefined && window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
+ }else if(Cookies.get('darkmode') === undefined && window.matchMedia('(prefers-color-scheme: dark)').matches) {
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/378#pullrequestreview-458044691">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSPWCZTISCGKWVEIE3R6DSLRANCNFSM4PE7L6JQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNT4MUIWVJCQ3FQDQNDR6DSLRA5CNFSM4PE7L6J2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODNGTKEY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/378#pullrequestreview-458044691",
"url": "https://github.com/bisq-network/bisq-website/pull/378#pullrequestreview-458044691",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>