<p></p>
<p><b>@pingiun</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463967473">seednode/docker/startSeedNode.sh</a>:</p>
<pre style='color:#555'>> @@ -28,4 +54,14 @@ if [ ! -z "$USE_LOCALHOST_FOR_P2P" ]; then
ARGS="$ARGS --useLocalhostForP2P=$USE_LOCALHOST_FOR_P2P"
fi
-JAVA_OPTS='-Xms1800m -Xmx1800m' ./build/app/bin/bisq-seednode $ARGS
+while true
+do
+
+ echo `date` "(Re)-starting node"
+
+ JAVA_OPTS='-Xms8192M -Xmx8192M -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=6969 -Dcom.sun.management.jmxremote.rmi.port=6969 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false' ./bin/bisq-seednode $ARGS 2>./error.log
</pre>
<p>I don't think jmx should be enabled by default</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463967540">seednode/docker/startSeedNode.sh</a>:</p>
<pre style='color:#555'>> @@ -28,4 +54,14 @@ if [ ! -z "$USE_LOCALHOST_FOR_P2P" ]; then
ARGS="$ARGS --useLocalhostForP2P=$USE_LOCALHOST_FOR_P2P"
fi
-JAVA_OPTS='-Xms1800m -Xmx1800m' ./build/app/bin/bisq-seednode $ARGS
+while true
</pre>
<p>Restarting shouldn't be builtin to the container, the docker itself can be restarted if needed</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463967603">seednode/docker/prod/openjdk.conf</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1 @@
+/usr/lib/jvm/java-11-openjdk-amd64/lib/server
</pre>
<p>What is this used for?</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463967887">seednode/docker/prod/Dockerfile-btc</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,7 @@
+FROM ruimarinho/bitcoin-core:0.18
</pre>
<p>I think we should prefer building the bitcoin node in the bisq source tree. It's pretty easy to make a Dockerfile for bitcoind, so this dependency is unnecessary</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463968013">seednode/docker/prod/Dockerfile</a>:</p>
<pre style='color:#555'>> -FROM openjdk:8-jdk
-
-RUN apt-get update && apt-get install -y --no-install-recommends \
- openjfx && rm -rf /var/lib/apt/lists/*
-
-WORKDIR /bisq-seednode
-CMD ./docker/startSeedNode.sh
-
-ENV APP_NAME=seednode
-ENV NODE_PORT=8000
+# first the builder builds the executables
+###
+FROM gradle:jdk11 as builder
+ARG SEEDNODE_URL
+ARG SEEDNODE_BRANCH
+RUN git clone $SEEDNODE_URL
</pre>
<p>This is already in the same repository as the seednode code, we can use local data instead of fetching it from github</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463968143">seednode/.dockerignore</a>:</p>
<pre style='color:#555'>> @@ -5,7 +5,7 @@ docs/
.travis.yml
docker-compose.yml
docker/development/
-docker/prod/
+#docker/prod/
</pre>
<p>I think this line and docker/development can be removed?</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463968243">seednode/docker/startSeedNode.sh</a>:</p>
<pre style='color:#555'>> @@ -28,4 +54,14 @@ if [ ! -z "$USE_LOCALHOST_FOR_P2P" ]; then
ARGS="$ARGS --useLocalhostForP2P=$USE_LOCALHOST_FOR_P2P"
fi
-JAVA_OPTS='-Xms1800m -Xmx1800m' ./build/app/bin/bisq-seednode $ARGS
+while true
</pre>
<p>Instead of restarting for when bitcoind has not started yet, detect whether bitcoind has started and sleep when not</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463968359">seednode/docker/prod/collectd.conf</a>:</p>
<pre style='color:#555'>> + Attribute "Usage"
+ </Value>
+ </MBean>
+
+ <Connection>
+ ServiceURL "service:jmx:rmi:///jndi/rmi://172.28.1.3:6969/jmxrmi"
+ Collect "memory_pool"
+ Collect "memory"
+ </Connection>
+
+ # See /usr/share/doc/collectd/examples/GenericJMX.conf
+ # for an example config.
+ </Plugin>
+</Plugin>
+
+#<Plugin load>
</pre>
<p>Don't comment out lines, remove them</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/3095#discussion_r463968392">seednode/docker-compose.yml</a>:</p>
<pre style='color:#555'>> volumes:
- - m2:/root/.m2
+ - ./docker/prod/blocknotify:/home/bitcoin/.bitcoin/blocknotify
+ - ${BTC_DATA_DIR}:/home/bitcoin/.bitcoin/
+ networks:
+ bisq_net:
+ ipv4_address: 172.28.1.2
+
+ nginx:
</pre>
<p>Why is the nginx container necessary?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/3095#pullrequestreview-459581925">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRRNO2IO4DGPCY3KJTR6QSXZANCNFSM4IL6KVYQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWPLRM2TB5NADWKRETR6QSXZA5CNFSM4IL6KVY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODNSKTZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/3095#pullrequestreview-459581925",
"url": "https://github.com/bisq-network/bisq/pull/3095#pullrequestreview-459581925",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>