<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<p>This implementation throws away all old tradestats data and doesn't allow for any historical lookup. What is the plan for allowing historical data?</p>
<p>Instead of throwing data away during pruning it should probably be stored locally as HistoricalTradeStats which would work a bit like the split stores in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="611982724" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4233" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4233/hovercard" href="https://github.com/bisq-network/bisq/pull/4233">#4233</a> except it's not a fixed block, but rather an append store but it can be excluded for all non historical data requests to seeds.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4405#discussion_r467439370">p2p/src/main/java/bisq/network/p2p/storage/payload/PrunablePersistableNetworkPayload.java</a>:</p>
<pre style='color:#555'>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.network.p2p.storage.payload;
+
+import bisq.common.Payload;
+
+/**
+ * Interface for PersistableNetworkPayloads which can be pruned (e.g. old objects will be removed from data store).
+ */
+public interface PrunablePersistableNetworkPayload extends Payload {
</pre>
<p>Is there a reason to not let this inherit from <code>PersistableNetworkPayload</code>? That would make more sense to me.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4405#pullrequestreview-463793592">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTGTRRZ52N7ZTZL7E3R7UQTLANCNFSM4PYOAQCQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWJA74O3CUY4H6AILTR7UQTLA5CNFSM4PYOAQC2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODOSO3OA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4405#pullrequestreview-463793592",
"url": "https://github.com/bisq-network/bisq/pull/4405#pullrequestreview-463793592",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>