<p></p>
<p><b>@sqrrm</b> approved this pull request.</p>
<p>ACK</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r472056530">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>:</p>
<pre style='color:#555'>> + }
+
+ protected final void lockWallet() {
+ //noinspection ResultOfMethodCallIgnored
+ grpcStubs.walletsService.lockWallet(createLockWalletRequest());
+ }
+
+ protected final String getUnusedBtcAddress() {
+ return grpcStubs.walletsService.getFundingAddresses(createGetFundingAddressesRequest())
+ .getAddressBalanceInfoList()
+ .stream()
+ .filter(a -> a.getBalance() == 0 && a.getNumConfirmations() == 0)
+ .findFirst()
+ .get()
+ .getAddress();
+
</pre>
⬇️ Suggested change
<pre style="color: #555">-
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r472060011">apitest/src/test/java/bisq/apitest/method/WalletProtectionTest.java</a>:</p>
<pre style='color:#555'>> + var request = createLockWalletRequest();
+ grpcStubs.walletsService.lockWallet(request);
+
+ Throwable exception = assertThrows(StatusRuntimeException.class, this::getBalance);
+ assertEquals("UNKNOWN: wallet is locked", exception.getMessage());
+ }
+
+ @Test
+ @Order(6)
+ public void testLockWalletWhenWalletAlreadyLockedShouldThrowException() {
+ var request = createLockWalletRequest();
+
+ Throwable exception = assertThrows(StatusRuntimeException.class, () ->
+ grpcStubs.walletsService.lockWallet(request));
+ assertEquals("UNKNOWN: wallet is already locked", exception.getMessage());
+
</pre>
⬇️ Suggested change
<pre style="color: #555">-
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4366#discussion_r472018467">apitest/src/main/java/bisq/apitest/linux/BitcoinDaemon.java</a>:</p>
<pre style='color:#555'>> @@ -55,6 +55,7 @@ public void start() throws InterruptedException, IOException {
+ " -txindex=1"
+ " -peerbloomfilters=1"
+ " -debug=net"
+ + " -fallbackfee=0.0002"
</pre>
<p>I think this is reasonable. These tests should never be used to start a live bitcoind.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4366#pullrequestreview-469118829">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ4DXINIXBCZQ4HKC3SBJIO7ANCNFSM4OV5LEEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVS7RMMLKNGL4OBZOLSBJIO7A5CNFSM4OV5LEE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODP3C63I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4366#pullrequestreview-469118829",
"url": "https://github.com/bisq-network/bisq/pull/4366#pullrequestreview-469118829",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>