<p></p>
<p><b>@jmacxx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4421#discussion_r474321090">core/src/main/java/bisq/core/trade/asset/xmr/XmrProofInfo.java</a>:</p>
<pre style='color:#555'>> +                        if (confirmations < confirmsRequired)
+                            // we return TX_NOT_CONFIRMED which will cause a retry later
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.TX_NOT_CONFIRMED);
+                        else
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.PROOF_OK);
+                    }
+                }
+            }
+
+            // reaching this point means there was no matching amount
+            return new XmrProofResult(XmrProofResult.State.AMOUNT_NOT_MATCHING, null);
+
+            // TODO check if date of tx is after tradeDate (allow some tolerance to avoid clock sync issues).
+            //  Otherwise a scammer could send an old txKey from a prev trade with same amount before seller has
+            //  updated to new feature, thus the check for duplication would not detect the scam.
+            //  >>>>> the API does not provide date of tx <<<<<<
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> how important is it to get tradeDate from the monero API, as it is not currently there?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4421#pullrequestreview-472044756">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSDLGD2I5OOTQUN3KDSBWUZRANCNFSM4QGSBOGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV4OQBC4LCVYMGOFH3SBWUZRA5CNFSM4QGSBOG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODQRNJVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4421#pullrequestreview-472044756",
"url": "https://github.com/bisq-network/bisq/pull/4421#pullrequestreview-472044756",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>