<p></p>
<p><b>@jmacxx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4421#discussion_r475111944">core/src/main/java/bisq/core/trade/asset/xmr/XmrProofInfo.java</a>:</p>
<pre style='color:#555'>> +                        if (confirmations < confirmsRequired)
+                            // we return TX_NOT_CONFIRMED which will cause a retry later
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.TX_NOT_CONFIRMED);
+                        else
+                            return new XmrProofResult(confirmations, confirmsRequired, XmrProofResult.State.PROOF_OK);
+                    }
+                }
+            }
+
+            // reaching this point means there was no matching amount
+            return new XmrProofResult(XmrProofResult.State.AMOUNT_NOT_MATCHING, null);
+
+            // TODO check if date of tx is after tradeDate (allow some tolerance to avoid clock sync issues).
+            //  Otherwise a scammer could send an old txKey from a prev trade with same amount before seller has
+            //  updated to new feature, thus the check for duplication would not detect the scam.
+            //  >>>>> the API does not provide date of tx <<<<<<
</pre>
<p>Incorporated trade date verification, I chose a tolerance window of 1 day.  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/9a2e28cbb3abf6b0ba408f1c97c04845ea485ee5/hovercard" href="https://github.com/bisq-network/bisq/commit/9a2e28cbb3abf6b0ba408f1c97c04845ea485ee5"><tt>9a2e28c</tt></a>  Now the example trades won't auto-confirm since they are too old!  <g-emoji class="g-emoji" alias="wink" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f609.png">😉</g-emoji></p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/90962013-6a5b6280-e472-11ea-8337-ee6497b8dc6e.png"><img src="https://user-images.githubusercontent.com/47253594/90962013-6a5b6280-e472-11ea-8337-ee6497b8dc6e.png" alt="image" style="max-width:100%;"></a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4421#discussion_r475111944">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW2JGGAQTEHU5YUSILSB75RHANCNFSM4QGSBOGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNR7PZMZA5VK2YZ7KITSB75RHA5CNFSM4QGSBOG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODQYH26I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4421#discussion_r475111944",
"url": "https://github.com/bisq-network/bisq/pull/4421#discussion_r475111944",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>