<p>Related: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="550739236" data-permission-text="Title is private" data-url="https://github.com/bisq-network/proposals/issues/170" data-hovercard-type="issue" data-hovercard-url="/bisq-network/proposals/issues/170/hovercard" href="https://github.com/bisq-network/proposals/issues/170">bisq-network/proposals#170</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="406692231" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/2369" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2369/hovercard" href="https://github.com/bisq-network/bisq/issues/2369">#2369</a></p>
<p>From the proposal and the discussion in Keybase it is clear that the USDT token is wanted on Bisq. This PR adds basic support for the ERC20 based token and the Omni based token.</p>
<p>I think a discussion should be had about the best way to make this implementation better. As of now, it adds two altcoins and thus two new markets are possible. I think it can be improved by joining these accounts or these markets in some way, for when users want to be able to trade both versions of USDT. On centralised markets there is only one USDT/XBT market, and the two tokens are considered equal. I think this behaviour is desirable.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4434'>https://github.com/bisq-network/bisq/pull/4434</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add Tether token support via ERC20 and Omni</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4434/files#diff-8c6790b73e7fe713f894bbe11d920ea2">assets/src/main/java/bisq/asset/coins/TetherOmni.java</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4434/files#diff-ae8a645ad5b49b9cd206dddaf0d3ca2f">assets/src/main/java/bisq/asset/tokens/TetherERC20.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4434/files#diff-80fd1cee0a0c612faa766609051a5342">assets/src/main/resources/META-INF/services/bisq.asset.Asset</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4434/files#diff-ce6bfda970634ec73863877d6cc61888">desktop/src/main/java/bisq/desktop/main/MainView.java</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4434.patch'>https://github.com/bisq-network/bisq/pull/4434.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4434.diff'>https://github.com/bisq-network/bisq/pull/4434.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4434">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWJ2IVICHPDE3FDUGTSCP62LANCNFSM4QK6QUVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXPAPVRJRPGDCUHNG3SCP62LA5CNFSM4QK6QUV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KG64SRA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4434",
"url": "https://github.com/bisq-network/bisq/pull/4434",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>