<p></p>
<p><b>@jmacxx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4421#discussion_r476548189">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -2493,8 +2506,8 @@ showWalletDataWindow.walletData=Wallet data
 showWalletDataWindow.includePrivKeys=Include private keys
 
 setXMRTxKeyWindow.headline=Prove sending of XMR
-setXMRTxKeyWindow.txHash=Transaction hash
-setXMRTxKeyWindow.txKey=Tx private key
+setXMRTxKeyWindow.txHash=Transaction id
+setXMRTxKeyWindow.txKey=Tx key
</pre>
<p>How about "Transaction key" instead?  The term "private key" always raises red flags because we are conditioned to never reveal our private keys.</p>
<ul>
<li><a href="https://www.getmonero.org/resources/user-guides/prove-payment.html" rel="nofollow">https://www.getmonero.org/resources/user-guides/prove-payment.html</a> refers to it as "the transaction's key".  Their web form calls it a "secret transaction key", slightly less intimidating without the word private.</li>
<li>monero-wallet-cli also calls it tx key: <code>get_tx_key TXID</code></li>
<li><a href="https://monero.stackexchange.com/questions/1860/how-do-i-prove-that-a-payment-has-been-sent-to-a-particular-address/1861" rel="nofollow">https://monero.stackexchange.com/questions/1860/how-do-i-prove-that-a-payment-has-been-sent-to-a-particular-address/1861</a> they call it transaction key.</li>
<li><a href="https://github.com/moneroexamples/onion-monero-blockchain-explorer">https://github.com/moneroexamples/onion-monero-blockchain-explorer</a> calls it <code>viewkey</code>.</li>
<li>Bisq's contract text for XMR account creation calls it <code>Transaction key</code> three times, and also gives synonyms <code>Tx Key, Tx Secret Key or Tx Private Key</code></li>
<li><a href="https://xmr.llcoins.net/checktx.html" rel="nofollow">https://xmr.llcoins.net/checktx.html</a> does use "private key" though.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4421#discussion_r476548189">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSSDXBR7E474XWJHWTSCPLWXANCNFSM4QGSBOGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVNRH6LMI5AE524ZDTSCPLWXA5CNFSM4QGSBOG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODRE7YAI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4421#discussion_r476548189",
"url": "https://github.com/bisq-network/bisq/pull/4421#discussion_r476548189",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>