<p>A unique hard coded debug listening port is assigned to the different Bisq app types in the <code>BisqAppConfig</code> enum, and background Bisq apps will be started with remote debug options if the scaffold-setup method is passed an <code>--enableBisqDebugging=true</code> option.</p>
<ul>
<li>
<p>Added <code>enableBisqDebugging</code> (default=false) option to <code>ApiTestConfig</code>.</p>
</li>
<li>
<p>Added <code>remoteDebugPort</code> field to <code>BisqAppConfig</code> enum.</p>
</li>
<li>
<p>Added <code>debugOpts</code> field to <code>BisqApp</code> (using <code>BisqAppConfig#remoteDebugPort</code>).</p>
</li>
<li>
<p>Appends <code>debugOpts</code> to exported <code>JAVA_OPTS</code> environment variable if present.</p>
</li>
<li>
<p>Removed messy quotes from <code>BisqAppConfig</code> enum <code>javaOpts</code> values.</p>
</li>
<li>
<p>Removed redundant return statement from <code>BisqApp#shutdown()</code>.</p>
</li>
</ul>
<p><em>PR 5 of 5, to be reviewed/merged in PR number order.</em></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4433'>https://github.com/bisq-network/bisq/pull/4433</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix setUpScaffold() signature</li>
  <li>Move :cli test.sh to :apitest mainnet-test.sh</li>
  <li>Remove duplicated grpc stub creation logic</li>
  <li>Remove redundant ApiTestConfig options</li>
  <li>Allow remote debugging of background Bisq apps</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-2e75814f8e05472c745f29bef59dd621">apitest/scripts/mainnet-test.sh</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-37f4744bd942b58d3fb57a379e71ef67">apitest/src/main/java/bisq/apitest/Scaffold.java</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-258dfd0a8fbc6ff5fc1c68369d4b76a0">apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java</a>
    (39)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-3d00c8a308ee19de9fe6bf66ac9a6812">apitest/src/main/java/bisq/apitest/config/BisqAppConfig.java</a>
    (42)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-fc6ba16b892341b73714491f514ff95c">apitest/src/main/java/bisq/apitest/linux/BisqApp.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-2b486b2248b88650958a2fabbcc673ba">apitest/src/test/java/bisq/apitest/ApiTestCase.java</a>
    (13)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-d28e94a1632ea686f9f8ca8b7a00f95a">apitest/src/test/java/bisq/apitest/GrpcStubs.java</a>
    (109)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-c373779aeb2c0f02199d152b537b0fd1">cli/src/main/java/bisq/cli/CliMain.java</a>
    (20)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4433/files#diff-fc12d88e0e22b3ab3dd9dbf67fe565a7">cli/src/main/java/bisq/cli/GrpcStubs.java</a>
    (54)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4433.patch'>https://github.com/bisq-network/bisq/pull/4433.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4433.diff'>https://github.com/bisq-network/bisq/pull/4433.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4433">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS6MA7EJGNU67P2E2TSCPQRRANCNFSM4QK27J7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUVN6R5HUFUEFE3CGLSCPQRRA5CNFSM4QK27J72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KG5YH5A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4433",
"url": "https://github.com/bisq-network/bisq/pull/4433",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>