<p></p>
<p><b>@sqrrm</b> approved this pull request.</p>

<p>utACK</p>
<p>Looks ok, but I'll leave a but in case <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> wants to act on my comment</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4445#discussion_r479381409">core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java</a>:</p>
<pre style='color:#555'>> +        // We wrap our periodic check in a delay of 2 hours to avoid that we get
+        // triggered multiple times after a restart while being in the same hour. It can be that we miss our target
+        // hour during that delay but that is not considered problematic, the seed would just restart a bit longer than
+        // 24 hours.
+        int target = myIndex;
+        UserThread.runAfter(() -> {
+            // We check every hour if we are in the target hour.
+            UserThread.runPeriodically(() -> {
+                int currentHour = ZonedDateTime.ofInstant(Instant.now(), ZoneId.of("GMT0")).getHour();
+                if (currentHour == target) {
+                    log.warn("\n\n%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n" +
+                            "Shut down node at hour {}" +
+                            "\n%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%\n\n", target);
+                    shutDown(gracefulShutDownHandler);
+                }
+            }, TimeUnit.MINUTES.toSeconds(10));
</pre>
<p>Why not use <code>CHECK_SHUTDOWN_SEC</code> here?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4445#pullrequestreview-477828395">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTF3DNG5I7SQTI7SVTSC7FJFANCNFSM4QN2PAEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUJ33VOVZCUVBYZRJLSC7FJFA5CNFSM4QN2PAE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODR5RKKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4445#pullrequestreview-477828395",
"url": "https://github.com/bisq-network/bisq/pull/4445#pullrequestreview-477828395",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>