<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>
<p>I have tested this and it keeps the sign status.</p>
<p>Would be good if someone with revolut knowledge acked before merge.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4453#discussion_r480046235">desktop/src/main/java/bisq/desktop/util/validation/RevolutValidator.java</a>:</p>
<pre style='color:#555'>> @@ -17,10 +17,13 @@
package bisq.desktop.util.validation;
-public final class RevolutValidator extends PhoneNumberValidator {
+public final class RevolutValidator extends LengthValidator {
</pre>
<p>I would like someone with knowledge of this requirement to weigh in before merging.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4453#discussion_r480046414">desktop/src/main/java/bisq/desktop/main/overlays/windows/UpdateRevolutAccountWindow.java</a>:</p>
<pre style='color:#555'>> + @Override
+ public void show() {
+ if (headLine == null)
+ headLine = Res.get("payment.revolut.addUserNameInfo.headLine");
+
+ width = 868;
+ createGridPane();
+ addHeadLine();
+ addContent();
+ addButtons();
+ applyStyles();
+ display();
+ }
+
+ private void addContent() {
+ addLabel(gridPane, ++rowIndex, Res.get("payment.account.revolut.addUserNameInfo", Res.get("payment.revolut.info"), revolutAccount.getAccountName()));
</pre>
<p>Keeping lines shorter helps the reviewer. and it would also be in accordance with our style guide.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4453#discussion_r480047023">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>:</p>
<pre style='color:#555'>> + // it has been the case before
+ String input = this.accountId == null ? "" : this.accountId;
+ return super.getAgeWitnessInputData(input.getBytes(StandardCharsets.UTF_8));
+ }
+
+ public void setUserName(@Nullable String userName) {
+ this.userName = userName;
+ // We only set accountId to userName for new accounts. Existing accounts have accountId set with email
+ // or phone nr. and we keep that to not break account signing.
+ if (accountId == null) {
+ accountId = userName;
+ }
+ }
+
+ public String getUserName() {
+ return userName != null ? userName : accountId;
</pre>
<p>Is this safe now that accountId can be null as well?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4453#pullrequestreview-478506367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTW3UXEIVR2JHNMTZLSDORFHANCNFSM4QP22DPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTTF43W3TX5JJAOE6LSDORFHA5CNFSM4QP22DPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODSCW27Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4453#pullrequestreview-478506367",
"url": "https://github.com/bisq-network/bisq/pull/4453#pullrequestreview-478506367",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>