<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4453#discussion_r480182006">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>:</p>
<pre style='color:#555'>> +        // it has been the case before
+        String input = this.accountId == null ? "" : this.accountId;
+        return super.getAgeWitnessInputData(input.getBytes(StandardCharsets.UTF_8));
+    }
+
+    public void setUserName(@Nullable String userName) {
+        this.userName = userName;
+        // We only set accountId to userName for new accounts. Existing accounts have accountId set with email
+        // or phone nr. and we keep that to not break account signing.
+        if (accountId == null) {
+            accountId = userName;
+        }
+    }
+
+    public String getUserName() {
+        return userName != null ? userName : accountId;
</pre>
<p>I reverted accountId to empty string. Is prob. more safe. getUserName returns then also empty string by default at account creation.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4453#discussion_r480182006">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUDQ42JWHOOX2FSNWDSDO2ALANCNFSM4QP22DPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSRF4RX5Z3L35ZNI2TSDO2ALA5CNFSM4QP22DPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODSEB5PI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4453#discussion_r480182006",
"url": "https://github.com/bisq-network/bisq/pull/4453#discussion_r480182006",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>