<p></p>
<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4233#discussion_r481106191">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>:</p>
<pre style='color:#555'>> @@ -205,24 +214,61 @@ public GetUpdatedDataRequest buildGetUpdatedDataRequest(NodeAddress senderNodeAd
         return new GetUpdatedDataRequest(senderNodeAddress, nonce, this.getKnownPayloadHashes());
     }
 
+    /**
+     * Create the special key. <br><br>
</pre>
<p>I somehow can agree on 'special key' to not be ideal. Fix coming up...</p>
<p>On the other hand, I fully agree on manipulating Version strings is downright bad and not desirable. However, refactoring <code>version</code> format would affect big portions of Bisq. Thus, it would directly violate our doctrine of keeping PR small and right to the point. One has to draw the line somewhere, here it is.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4233#discussion_r481106191">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSWWBZAJ6ZFU37JWPLSDTTUFANCNFSM4MY33J4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNULXSM22KPEKX7LHQLSDTTUFA5CNFSM4MY33J4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODSL2B3Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4233#discussion_r481106191",
"url": "https://github.com/bisq-network/bisq/pull/4233#discussion_r481106191",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>