<p>This PR ensures a daemon never creates more than one <code>CoreApi</code> instance, but two additional, minor changes are included:</p>
<ul>
<li>
<p>Add <code>@VisibleForTesting</code> annotation to <code>CompositeOptionSet</code> to explain why it is no longer package protected.</p>
</li>
<li>
<p>Remove commented code from <code>BisqAppMain</code>.</p>
</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4461'>https://github.com/bisq-network/bisq/pull/4461</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Make CoreApi a singleton</li>
  <li>Add @VisibleForTesting annotation</li>
  <li>Remove commented code from BisqAppMain</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4461/files#diff-d12cf13a514fbb664736c008ecc24df6">common/src/main/java/bisq/common/config/CompositeOptionSet.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4461/files#diff-defe707a4d38994a1dd5a818fc078522">core/src/main/java/bisq/core/api/CoreApi.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4461/files#diff-ec9bc1424bfac1a452063f102ef3ef5e">desktop/src/main/java/bisq/desktop/app/BisqAppMain.java</a>
    (14)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4461.patch'>https://github.com/bisq-network/bisq/pull/4461.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4461.diff'>https://github.com/bisq-network/bisq/pull/4461.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4461">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS4X2NKOR7B6EEYJVDSDURN3ANCNFSM4QR6JBFQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNX4SYDXPH2BNGJ2H7LSDURN3A5CNFSM4QR6JBF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KJFER6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4461",
"url": "https://github.com/bisq-network/bisq/pull/4461",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>