<p></p>
<p><b>@sqrrm</b> requested changes on this pull request.</p>

<p>The Revolut stuff looks good. I haven't tested it, so utACK on those parts.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4481#discussion_r483956764">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java</a>:</p>
<pre style='color:#555'>> @@ -157,13 +154,19 @@ public void activate() {
             }
         });
 
-        // we listen for updates on the trade autoConfirmResult field
-        if (assetTxProofResultField != null) {
-            trade.getAssetTxProofResultUpdateProperty().addListener(proofResultListener);
+        if (useXmrTxProof) {
+            proofResultListener = (observable, oldValue, newValue) -> {
+                applyAssetTxProofResult(trade.getAssetTxProofResult());
+            };
+
+            // we listen for updates on the trade autoConfirmResult field
+            if (assetTxProofResultField != null) {
+                trade.getAssetTxProofResultUpdateProperty().addListener(proofResultListener);
+                applyAssetTxProofResult(trade.getAssetTxProofResult());
</pre>
<p>This will be done in the next statement anyway</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4481#discussion_r483956780">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java</a>:</p>
<pre style='color:#555'>> @@ -157,13 +154,19 @@ public void activate() {
             }
         });
 
-        // we listen for updates on the trade autoConfirmResult field
-        if (assetTxProofResultField != null) {
-            trade.getAssetTxProofResultUpdateProperty().addListener(proofResultListener);
+        if (useXmrTxProof) {
+            proofResultListener = (observable, oldValue, newValue) -> {
+                applyAssetTxProofResult(trade.getAssetTxProofResult());
+            };
+
+            // we listen for updates on the trade autoConfirmResult field
+            if (assetTxProofResultField != null) {
+                trade.getAssetTxProofResultUpdateProperty().addListener(proofResultListener);
+                applyAssetTxProofResult(trade.getAssetTxProofResult());
</pre>

⬇️ Suggested change
<pre style="color: #555">-                applyAssetTxProofResult(trade.getAssetTxProofResult());
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4481#discussion_r483957477">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>:</p>
<pre style='color:#555'>> @@ -105,7 +110,34 @@ public static RevolutAccountPayload fromProto(protobuf.PaymentAccountPayload pro
 
     @Override
     public String getPaymentDetails() {
-        return Res.get(paymentMethodId) + " - " + Res.getWithCol("payment.account.userName") + " " + getUserName();
+        Tuple2<String, String> tuple = getLabelValueTuple();
+        return Res.get(paymentMethodId) + " - " + tuple.first + ": " + tuple.second;
+    }
+
+    private Tuple2<String, String> getLabelValueTuple() {
</pre>
<p>This is kind of a mess, but seems correct.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4481#discussion_r483957664">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>:</p>
<pre style='color:#555'>> +            label = Res.get("payment.account.userName");
+            value = userName;
+
+            if (hasOldAccountId()) {
+                label += "/" + Res.get("payment.account.phoneNr");
+                value += "/" + accountId;
+            }
+        } else {
+            label = Res.get("payment.account.phoneNr");
+            value = accountId;
+        }
+        return new Tuple2<>(label, value);
+    }
+
+    public Tuple2<String, String> getRecipientsAccountData() {
+        Tuple2<String, String> tuple = getLabelValueTuple();
</pre>
<p>Using <code>var tuple</code> really helps make the code cleaner and easier to read in cases like this. Although that's personal preference.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-483059053">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUVV27BSH2KRPIICRDSEJGVNANCNFSM4QZUXA5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNX4QPIIIUBGSBWLWNLSEJGVNA5CNFSM4QZUXA5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODTFOK3I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-483059053",
"url": "https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-483059053",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>