<p></p>
<p><b>@chimp1984</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4504#discussion_r485275356">core/src/main/java/bisq/core/btc/setup/BisqKeyChainGroupStructure.java</a>:</p>
<pre style='color:#555'>> +            new ChildNumber(142, true),
+            ChildNumber.ZERO_HARDENED);
+
+    public static final ImmutableList<ChildNumber> BIP44_BSQ_SEGWIT_ACCOUNT_PATH = ImmutableList.of(
+            new ChildNumber(44, true),
+            new ChildNumber(142, true),
+            ChildNumber.ONE_HARDENED);
+
+    private boolean isBsqWallet;
+
+    public BisqKeyChainGroupStructure (boolean isBsqWallet) {
+        this.isBsqWallet = isBsqWallet;
+    }
+
+    @Override
+    public ImmutableList<ChildNumber> accountPathFor(Script.ScriptType outputScriptType) {
</pre>
<p>Aren't there more script types (MultiSig) to check?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4504#discussion_r485275836">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>:</p>
<pre style='color:#555'>> @@ -172,7 +172,6 @@ public WalletsSetup(RegTestHost regTestHost,
 
         btcWalletFileName = "bisq_" + config.baseCurrencyNetwork.getCurrencyCode() + ".wallet";
         params = Config.baseCurrencyNetworkParameters();
-        PeerGroup.setIgnoreHttpSeeds(true);
</pre>
<p>Are httpSeed still used by default in BitcoinJ? If so I would prefer to still make sure to not use http seeds as they have some privacy issues.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4504#discussion_r485276437">core/src/main/java/bisq/core/btc/setup/WalletConfig.java</a>:</p>
<pre style='color:#555'>> @@ -495,6 +485,8 @@ private Wallet loadWallet(boolean shouldReplayWallet, File walletFile, boolean i
     }
 
     protected Wallet createWallet(boolean isBsqWallet) {
+        // Change preferredOutputScriptType of btc wallet to P2WPKH to start using segwit
+        Script.ScriptType preferredOutputScriptType = isBsqWallet ? Script.ScriptType.P2PKH : Script.ScriptType.P2PKH;
</pre>
<p>I guess the else case should be P2WPKH</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4504#pullrequestreview-484587743">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQXGSOH6Y5F2ZZIPDLSE3IAXANCNFSM4RAV7MIQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQD2YQQ6YTIL6IMBQ3SE3IAXA5CNFSM4RAV7MI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODTRDRXY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4504#pullrequestreview-484587743",
"url": "https://github.com/bisq-network/bisq/pull/4504#pullrequestreview-484587743",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>