<p>moment we save the account. Only at that moment we check if we need to<br>
set the accountId with the value of the userName.<br>
We do that in the domain layer to avoid more domain logic code in the UI<br>
layer.</p>
<p>Fixes bug found at:<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="693810966" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4481" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4481/hovercard?comment_id=485066342&comment_type=review" href="https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342">#4481 (review)</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4506'>https://github.com/bisq-network/bisq/pull/4506</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Remove side effect in setUserName method and add extra handling for the</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4506/files#diff-e26b3d3959d7b07ae76c718e12b397ba">core/src/main/java/bisq/core/payment/PaymentAccount.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4506/files#diff-d059caee7dd8f8b81e215bf11d297dae">core/src/main/java/bisq/core/payment/RevolutAccount.java</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4506/files#diff-5ed2b63cf6c49606094e30067768aafc">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4506/files#diff-99dd35d965ed0b14a3dc4ae199eee184">core/src/main/java/bisq/core/user/User.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4506.patch'>https://github.com/bisq-network/bisq/pull/4506.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4506.diff'>https://github.com/bisq-network/bisq/pull/4506.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4506">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW6KZRGPXLLS5BYPTLSE6WALANCNFSM4RCXDGAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRI64ZQC6BG7XHC7PTSE6WALA5CNFSM4RCXDGA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KMK7VFQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4506",
"url": "https://github.com/bisq-network/bisq/pull/4506",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>