<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4481#discussion_r485655020">core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java</a>:</p>
<pre style='color:#555'>> +    public void setUserName(String userName) {
+        this.userName = userName;
+        // We need to set accountId as pre v1.3.8 clients expect the accountId field
+        if (accountId.isEmpty()) {
+            accountId = userName;
+        }
</pre>
<p>I just tried to create a new Revolut account and saw that it doesn't behave as expected.</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/92611346-fb2a9e80-f2b8-11ea-95b4-dd9e2dcaef61.png"><img src="https://user-images.githubusercontent.com/170962/92611346-fb2a9e80-f2b8-11ea-95b4-dd9e2dcaef61.png" alt="Bildschirmfoto 2020-09-09 um 16 12 09" style="max-width:100%;"></a><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/92611362-fe258f00-f2b8-11ea-8622-50f92e1dfe87.png"><img src="https://user-images.githubusercontent.com/170962/92611362-fe258f00-f2b8-11ea-8622-50f92e1dfe87.png" alt="Bildschirmfoto 2020-09-09 um 16 13 35" style="max-width:100%;"></a></p>
<p>The problem is that it is checked at this place if the accountId is empty which will only work for the first character entered into the field e.g. <code>B</code> of <code>Bobby</code> this ends up with <code>accountId</code> set to <code>B</code> and userName set to <code>Bobby</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQKWDV5AGJLSPJLFZ3SE6GBZANCNFSM4QZUXA5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNT56RMSNECABD7B27TSE6GBZA5CNFSM4QZUXA5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODTUYMZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342",
"url": "https://github.com/bisq-network/bisq/pull/4481#pullrequestreview-485066342",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>