<p>Depends on <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="699772196" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4516" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4516/hovercard" href="https://github.com/bisq-network/bisq/pull/4516">#4516</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4517'>https://github.com/bisq-network/bisq/pull/4517</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add check for refund agent if donation address is valid</li>
  <li>Dont allow opening refudn agent dispute if delayed payout tx is invalid.</li>
  <li>Improve address validation code</li>
  <li>Fix some issues found during testing</li>
  <li>Allow close dispute for refund agent without payout</li>
  <li>Call validatePayoutTx only after trades are initialized</li>
  <li>Dispute agent sign summary. Add tool for verification</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-89758c75d807456cc908d782f5b890a9">core/src/main/java/bisq/core/dao/DaoFacade.java</a>
    (25)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-cda7d40808cfbc74c5b87d210c3649b8">core/src/main/java/bisq/core/support/dispute/Dispute.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-27340c4c147f46b771dc7a08bbd38a6b">core/src/main/java/bisq/core/support/dispute/DisputeManager.java</a>
    (58)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-ad25145d2a5b56a4bcf0c91856f279de">core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-175b341b16337976b323e2347d4c74b2">core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-ace16f12e9aa58cdfb2b62922d7f4d62">core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-b98a7e2a1202ae268bbe0c49ab1d678c">core/src/main/java/bisq/core/trade/DelayedPayoutTxValidation.java</a>
    (196)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-0af080d552e467803896267f8199c544">core/src/main/java/bisq/core/trade/Trade.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-5bdbc074df621c9b94b16c72ca834894">core/src/main/java/bisq/core/trade/TradeManager.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-3de9415661594e285fd542a20e3179be">core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-f8bbcc118297c4959e138a6a5af83d68">core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-2b16c2ca0e92ce28cd7268b07a143647">core/src/main/resources/i18n/displayStrings.properties</a>
    (45)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-eec79f2b86bbe1a8aa8703519a5d9cbe">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-522c769925610d8eae301e8a3a5eccff">desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-0687516b9d17b1b6bdcf472ae7434fbc">desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java</a>
    (152)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-09d0ee1927aef5e87c3d4cb854fb30a2">desktop/src/main/java/bisq/desktop/main/overlays/windows/VerifyDisputeResultSignatureWindow.java</a>
    (97)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-62811e6004bb38ee1ee37843f31cc035">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-399b09e9372394aa01203b342358de71">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep1View.java</a>
    (56)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-e770e5c915ec3d9ac99a437272e29166">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java</a>
    (48)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-2f11706c83ab174dfbffbd39cfad8db5">desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeSummaryVerification.java</a>
    (107)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-58c7c15e2a4bf339d573f45a9d838bbd">desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-ea30f419e33ac565b5891e1a56a95f48">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-6c632874dafc703d50a1e492b30b4bd9">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/arbitration/ArbitratorView.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-e94ed2ab69d124c588a91eec4007fe13">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/mediation/MediatorView.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-ff24a6f029c55844cbeb191f3c09bb4a">desktop/src/main/java/bisq/desktop/main/support/dispute/agent/refund/RefundAgentView.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-098e0992d055ff9ddb11ebc2ce88cf16">desktop/src/main/java/bisq/desktop/main/support/dispute/client/DisputeClientView.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-05b9ee7fa9f4cb6f52a2ad6119cbb2ec">desktop/src/main/java/bisq/desktop/main/support/dispute/client/arbitration/ArbitrationClientView.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-5b316e826658b42f429891eac9618bbd">desktop/src/main/java/bisq/desktop/main/support/dispute/client/mediation/MediationClientView.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-27273e3826563c56cd5895a71b2bb6b6">desktop/src/main/java/bisq/desktop/main/support/dispute/client/refund/RefundClientView.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4517/files#diff-41caf249b58a6c497f396da0a67168e4">proto/src/main/proto/pb.proto</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4517.patch'>https://github.com/bisq-network/bisq/pull/4517.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4517.diff'>https://github.com/bisq-network/bisq/pull/4517.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4517">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSEOWQ42IIZA6K2GCDSFMCNDANCNFSM4RJBZLJQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTDAAKOZ52BH55NRNDSFMCNDA5CNFSM4RJBZLJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KN2LPUQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4517",
"url": "https://github.com/bisq-network/bisq/pull/4517",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>