<p></p>
<p><b>@chimp1984</b> requested changes on this pull request.</p>

<p>NACK</p>
<p>Basic concept is ok but many impl. elements are not acceptable IMO. Specially the hack to encode the version into the payload of the hashes instead of adding a new protobug field to the request msg.</p>
<p>I suggest that we use <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="700523039" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4519" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4519/hovercard" href="https://github.com/bisq-network/bisq/pull/4519">#4519</a> which is based on this PR one but has a lot of changes. It is still WIP and not much tested, should be ready for review in a few days...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4233#pullrequestreview-490179040">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTZXJHLC52KCDRHZV3SGFPTZANCNFSM4MY33J4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSSIR6SDJYGXGWNOM3SGFPTZA5CNFSM4MY33J4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODU3YTYA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4233#pullrequestreview-490179040",
"url": "https://github.com/bisq-network/bisq/pull/4233#pullrequestreview-490179040",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>