<p></p>
<p><b>@oscarguindzberg</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4504#discussion_r490570217">gradle/witness/gradle-witness.gradle</a>:</p>
<pre style='color:#555'>> @@ -68,22 +68,23 @@ dependencyVerification {
         'net.glxn:qrgen:c85d9d8512d91e8ad11fe56259a7825bd50ce0245447e236cf168d1b17591882',
         'net.jcip:jcip-annotations:be5805392060c71474bf6c9a67a099471274d30b83eef84bfc4e0889a4f1dcc0',
         'net.sf.jopt-simple:jopt-simple:df26cc58f235f477db07f753ba5a3ab243ebe5789d9f89ecf68dd62ea9a66c28',
-        'network.bisq.btcd-cli4j:btcd-cli4j-core:203156fc63dc1202774de9818e4f21149549f79b25d356b08bb0c784be40c0e8',
-        'network.bisq.btcd-cli4j:btcd-cli4j-daemon:0a2783a851add6e3d8ae899ade48c041b250bfac64b6a4c5f6380ebcdbbe6848',
+        'network.bisq.btcd-cli4j:btcd-cli4j-core:4634b39de93764c4609e295e254e8c3b1427ba24febf43352f4f315029c5b1b3',
</pre>
<p>Kind of long story...<br>
A year ago I upgraded some Bisq dependencies to match bitcoinj 0.15.1 dependencies. eg upgraded guava from 20 to 27.<br>
Then, when bitcoinj 0.15.8 came out with guava 28.2 , I upgraded Bisq to use that guava version.<br>
None of those changes were merged yet, we are merging it as part of this PR.</p>
<p>Some time ago this code was merged into the btcd-cli4j repo <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="445865831" data-permission-text="Title is private" data-url="https://github.com/bisq-network/btcd-cli4j/issues/4" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/btcd-cli4j/pull/4/hovercard" href="https://github.com/bisq-network/btcd-cli4j/pull/4">bisq-network/btcd-cli4j#4</a> . And then you reverted part of the change <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="488190040" data-permission-text="Title is private" data-url="https://github.com/bisq-network/btcd-cli4j/issues/8" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/btcd-cli4j/pull/8/hovercard" href="https://github.com/bisq-network/btcd-cli4j/pull/8">bisq-network/btcd-cli4j#8</a>.</p>
<p>So, I am not actually upgrading btcd-cli4j but downgrading it to the version that declares a dependency on guava 27.</p>
<p>In any case, bisq's gradle resolves not to include the guava version declared in btcd-cli4j but the version declared on its own build.gradle file.</p>
<p>To make things clear a new btcd-cli4j version declaring a dependency to guava 28.2-jre could be created, then we could upgrade to that btcd-cli4j version in bisq.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4504#discussion_r490570217">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSE3MM3PMTHKGM62GDSGJ5ATANCNFSM4RAV7MIQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTNYJOVGOHMEIYWRG3SGJ5ATA5CNFSM4RAV7MI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODVCA2AY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4504#discussion_r490570217",
"url": "https://github.com/bisq-network/bisq/pull/4504#discussion_r490570217",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>