<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4514#discussion_r490016926">core/src/main/java/bisq/core/trade/protocol/tasks/cancel/FinalizeCanceledTradePayoutTx.java</a>:</p>
<pre style='color:#555'>> +            Transaction depositTx = checkNotNull(trade.getDepositTx());
+            String tradeId = trade.getId();
+            TradingPeer tradingPeer = processModel.getTradingPeer();
+            BtcWalletService walletService = processModel.getBtcWalletService();
+            Offer offer = checkNotNull(trade.getOffer(), "offer must not be null");
+            Coin tradeAmount = checkNotNull(trade.getTradeAmount(), "tradeAmount must not be null");
+            Contract contract = checkNotNull(trade.getContract(), "contract must not be null");
+
+            checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not be null");
+
+            byte[] mySignature = checkNotNull(processModel.getCanceledTradePayoutTxSignature(),
+                    "processModel.getTxSignatureFromCanceledTrade must not be null");
+            byte[] peersSignature = checkNotNull(tradingPeer.getCanceledTradePayoutTxSignature(),
+                    "tradingPeer.getTxSignatureFromCanceledTrade must not be null");
+
+            boolean isMyRoleBuyer = contract.isMyRoleBuyer(processModel.getPubKeyRing());
</pre>
<p>Yeah, why is there a check for what role is active when we know it's the seller?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4514#discussion_r490016926">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQKIT6BRPU5XGTD7HLSGGYORANCNFSM4RGCTZBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSTR75HLZXP3BRZXEDSGGYORA5CNFSM4RGCTZBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODU4V37Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4514#discussion_r490016926",
"url": "https://github.com/bisq-network/bisq/pull/4514#discussion_r490016926",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>