<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4514#discussion_r490016431">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -833,6 +832,67 @@ public Transaction sellerSignsAndFinalizesPayoutTx(Transaction depositTx,
return payoutTx;
}
+ ///////////////////////////////////////////////////////////////////////////////////////////
+ // Canceled trade payoutTx
+ ///////////////////////////////////////////////////////////////////////////////////////////
+
+ public byte[] signCanceledTradePayoutTx(Transaction depositTx,
+ Coin buyerPayoutAmount,
+ Coin sellerPayoutAmount,
+ String buyerPayoutAddressString,
+ String sellerPayoutAddressString,
+ DeterministicKey myMultiSigKeyPair,
+ byte[] buyerPubKey,
+ byte[] sellerPubKey)
+ throws AddressFormatException, TransactionVerificationException {
+ Transaction preparedPayoutTx = createPayoutTx(depositTx, buyerPayoutAmount, sellerPayoutAmount, buyerPayoutAddressString, sellerPayoutAddressString);
</pre>
<p>This was just a general comment that long lines are hard to read.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4514#discussion_r490016431">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNR5CCPO7UD4WT34E7LSGGYLBANCNFSM4RGCTZBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQIY65SWAMC2FL6QELSGGYLBA5CNFSM4RGCTZBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODU4VXOI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4514#discussion_r490016431",
"url": "https://github.com/bisq-network/bisq/pull/4514#discussion_r490016431",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>