<p>This commit contains most of the changes suggested by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> in his api-suggestions branch.  See <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/961703ecea62df62946ab001ec28205662688ccd/hovercard" href="https://github.com/bisq-network/bisq/commit/961703ecea62df62946ab001ec28205662688ccd"><tt>961703e</tt></a></p>
<p>A new <code>registerdisputeagent</code> method was also added to <code>CliMain</code>, finishing the work to support registration of mediators and refund agents on arbitration daemons running in regtest mode.  This method cannot be used to register dispute agents on mainnet;  users will see an error msg if they try.  (The change was added to this PR to avoid likely <code>CliMain</code> file conflicts.)</p>
<p>This PR replaces <a href="https://github.com/bisq-network/bisq/pull/4526" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4526/hovercard">4526</a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4539'>https://github.com/bisq-network/bisq/pull/4539</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor API & add registerdisputeagent method to CLI</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-2e75814f8e05472c745f29bef59dd621">apitest/scripts/mainnet-test.sh</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-c373779aeb2c0f02199d152b537b0fd1">cli/src/main/java/bisq/cli/CliMain.java</a>
    (57)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-defe707a4d38994a1dd5a818fc078522">core/src/main/java/bisq/core/api/CoreApi.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-f905350d6a4eef257cb8420e5b52fcfb">core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-d7353096fea115841d9ac980fe68b3af">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
    (46)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-d4059c1d76936ff1d5186eb5730cb9a4">core/src/main/java/bisq/core/api/CorePaymentAccountsService.java</a>
    (86)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-fa258cf72caec92788e960e71c63d66f">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
    (36)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-6bf112c640b5c02ce35fdfcbdf43f916">core/src/main/java/bisq/core/btc/wallet/WalletService.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-99dd35d965ed0b14a3dc4ae199eee184">core/src/main/java/bisq/core/user/User.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-01a7cf00fcce84b3e03a47b3b1c81bbd">daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java</a>
    (23)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-b49ce28734bc18b139e3c27ce4f1f4a6">daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java</a>
    (37)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-073db9176bdbf520d57c0bb69bcde77e">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-eca81dac77bbe2b6a1ba4b39bfe38897">daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-cf9363e58d0ea299011282758a4aa8e3">daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java</a>
    (52)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-7d4bc7fff0244e2b7ab0e2748ce30411">daemon/src/main/java/bisq/daemon/grpc/GrpcVersionService.java</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-164f12ba196f3ba9788a17f81d798bfa">daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java</a>
    (19)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-bca3dcf8f4b682cd9e5961434ca7c59e">daemon/src/main/java/bisq/daemon/grpc/PasswordAuthInterceptor.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4539/files#diff-328b3309bc03d9ffb3ffb9e780dc7e91">proto/src/main/proto/grpc.proto</a>
    (14)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4539.patch'>https://github.com/bisq-network/bisq/pull/4539.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4539.diff'>https://github.com/bisq-network/bisq/pull/4539.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4539">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVSBFJSZQUQBEKP7JDSGNWPDANCNFSM4RSCYNQA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNW2Q55KCSUBL4EEKHDSGNWPDA5CNFSM4RSCYNQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KP42ATQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4539",
"url": "https://github.com/bisq-network/bisq/pull/4539",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>