<p></p>
<blockquote>
<p>The next time you force push or push with new commits to this PR the Codacy complaints should be gone.</p>
</blockquote>
<p>Thanks <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ripcurlx/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a></p>
<p>Talking about Codacy, I saw a lot of frustration around this tool recently, with people writing less-safe code (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="696272873" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4504" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4504/hovercard?comment_id=695133780&comment_type=issue_comment" href="https://github.com/bisq-network/bisq/pull/4504#issuecomment-695133780">#4504 (comment)</a>), or writing less-readable code<br>
(<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="696272873" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4504" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4504/hovercard?comment_id=695156510&comment_type=issue_comment" href="https://github.com/bisq-network/bisq/pull/4504#issuecomment-695156510">#4504 (comment)</a>), just to get the bot's approval and have their PRs mergeable.</p>
<p>Good news is that the problem is not with Codacy, but with how Bisq integrates it. I think now it's configured as a "mandatory" check that must pass before PRs can be merged into a protected branch. But it can be made "non-mandatory", so even if a check fails with a false positive, which happens often, if the reviewers ACK that PR, it could still be merged. See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="696272873" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4504" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4504/hovercard?comment_id=695207917&comment_type=issue_comment" href="https://github.com/bisq-network/bisq/pull/4504#issuecomment-695207917">#4504 (comment)</a> for details. Of course, if the checks fail and the reviewers agree with the bot, the PR author still has to fix what the bot found.</p>
<p>Might be worth considering, would spare devs and reviewers a lot of frustration :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4242#issuecomment-696875164">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQLBHVAOMAWIHFW753SHDO7JANCNFSM4M3JTONQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUYYS7Y5SMACSURLR3SHDO7JA5CNFSM4M3JTON2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGEXRHA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4242#issuecomment-696875164",
"url": "https://github.com/bisq-network/bisq/pull/4242#issuecomment-696875164",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>