<p></p>
<p><b>@cd2357</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r494134605">apitest/scripts/version-parser.bash</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,5 @@
+#!/bin/bash
+
+# Bats helper script for parsing current version from Version.java.
+
+export CURRENT_VERSION=$(grep "String VERSION =" common/src/main/java/bisq/common/app/Version.java | sed 's/[^0-9.]*//g')
</pre>
<p>Nit: wouldn't it be better to script this in gradle instead of bash?</p>
<p>It would be platform independent and it could be tested by more devs (not restricted to those using mac or linux).</p>
<p>It would also make integration with the current codebase easier, like accessing <code>Version.CURRENT_VERSION</code> natively here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4558#pullrequestreview-495337652">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTSY2VI2XDZVLZYIOTSHL7XBANCNFSM4RXFTUTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUUDEPNIG7BZSTBWVLSHL7XBA5CNFSM4RXFTUT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWDEBNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4558#pullrequestreview-495337652",
"url": "https://github.com/bisq-network/bisq/pull/4558#pullrequestreview-495337652",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>