<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r495198825">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>:</p>
<pre style='color:#555'>> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
@Override
public void createOffer(CreateOfferRequest req,
StreamObserver<CreateOfferReply> responseObserver) {
- TransactionResultHandler resultHandler = transaction -> {
- CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+ CountDownLatch latch = new CountDownLatch(1);
+ try {
+ TransactionResultHandler resultHandler = transaction -> {
+ latch.countDown();
</pre>
<p>In <code>GrpcOffersService</code>, there is a comment explaining why <code>OfferInfo</code> is used:</p>
<pre><code> // The client cannot see bisq.core.Offer or its fromProto method.
// We use the lighter weight OfferInfo proto wrapper instead, containing just
// enough fields to view and create offers.
</code></pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r495198825">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWO4UYNLQXI77LE4EDSHTX47ANCNFSM4RXFTUTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTPJJYEN7HJJJMNKN3SHTX47A5CNFSM4RXFTUT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWOAWPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4558#discussion_r495198825",
"url": "https://github.com/bisq-network/bisq/pull/4558#discussion_r495198825",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>