<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r495610803">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>:</p>
<pre style='color:#555'>> @@ -86,21 +90,53 @@ public void getOffers(GetOffersRequest req,
     @Override
     public void createOffer(CreateOfferRequest req,
                             StreamObserver<CreateOfferReply> responseObserver) {
-        TransactionResultHandler resultHandler = transaction -> {
-            CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build();
+        CountDownLatch latch = new CountDownLatch(1);
+        try {
+            TransactionResultHandler resultHandler = transaction -> {
+                latch.countDown();
</pre>
<p>Imagine my embarrassment... but I'm still stuck.  The resultHandler passed into coreApi.createOffer has not been initialized when all is moved to the handler directly, and it cannot compile.</p>
<p>BTW, this file was changed again in commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/82b7b79c5b4252fd6ecfcaac82b7cd4f5769c3b7/hovercard" href="https://github.com/bisq-network/bisq/commit/82b7b79c5b4252fd6ecfcaac82b7cd4f5769c3b7"><tt>82b7b79</tt></a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r495610803">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRV4W3SHSSXBEDW4ATSH6MENANCNFSM4RXFTUTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVZQZFL7HX57XI6I4LSH6MENA5CNFSM4RXFTUT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWQUEXA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4558#discussion_r495610803",
"url": "https://github.com/bisq-network/bisq/pull/4558#discussion_r495610803",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>