<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a></p>
<p>RE:  <a href="https://github.com/bisq-network/bisq/pull/4558#discussion_r495619071" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4558/hovercard">Why are there are two 'Offer createOffer()' createOffer methods?</a></p>
<p>(1) is for creating a new buy-or-sell order with a random offerId<br>
(2) is for creating a new buy-or-sell order with a given offerId</p>
<p>I think 2nd could be altered and/or renamed to use as a new 'placeoffer' method, where a cached Offer (in the single user daemon instance) created in the 1st is passed to the 2nd, after the user enters a 'placeoffer offer-id' command.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-497614888">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXLJHQTT6DHBOAVYCDSICPULANCNFSM4RXT56GA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVMZITFCBJ7BOKSGB3SICPULA5CNFSM4RXT56GKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWUQAKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-497614888",
"url": "https://github.com/bisq-network/bisq/pull/4559#pullrequestreview-497614888",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>